Annotate array_namespace and add py.typed #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be the only missing type annotation in the project.
|
Eventually, |
|
Any chance we could get this in before the next release?
|
crusaderky
approved these changes
Feb 27, 2025
|
Okay, CI is green after a rerun, let's get this in. Thanks @NeilGirdhar , thanks @crusaderky |
|
Thank you! |
|
It's worth pointing out that the addition of |
|
PSA: I am literally in the release process, and will carve it once gh-250 is green. |
|
@crusaderky Awesome, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be the only missing type annotation in the project.